Fix keymap icon positioning in codemirror #12269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This modifies the CSS in
shell/components/CodeMirror.vue
so that styles can properly be applied to the keymap icons..codemirror-container
and.keymap.overlay
are siblings in the rendered DOM output. This change in styles reflects that.There's now duplication in the grouping of our
.code-mirror
styles inCodeMirror.vue
. I'm opting to leave the separate to reduce the amount of churn in this change, but I'm completely open to merging the two groups if we feel that's the best for future maintenance.Fixes #12195
Occurred changes and/or fixed issues
shell/components/CodeMirror.vue
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist