Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keymap icon positioning in codemirror #12269

Merged

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Oct 15, 2024

Summary

This modifies the CSS in shell/components/CodeMirror.vue so that styles can properly be applied to the keymap icons.

.codemirror-container and .keymap.overlay are siblings in the rendered DOM output. This change in styles reflects that.

There's now duplication in the grouping of our .code-mirror styles in CodeMirror.vue. I'm opting to leave the separate to reduce the amount of churn in this change, but I'm completely open to merging the two groups if we feel that's the best for future maintenance.

Fixes #12195

Occurred changes and/or fixed issues

  • Refactor styles in shell/components/CodeMirror.vue

Areas or cases that should be tested

  • CodeMirror styles
  • CodeMirror with keymaps defined

Areas which could experience regressions

  • CodeMirror styles

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rak-phillip rak-phillip merged commit 8621d3a into rancher:master Oct 16, 2024
39 checks passed
@rak-phillip rak-phillip deleted the bugfix/12195-yaml-icon-display branch October 16, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue3: YAML Editor Key Mapping: 'Normal Human' keyboard icon display issues
2 participants